-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add combinators for Ω (addresses #43) #48
Add combinators for Ω (addresses #43) #48
Conversation
Just above the message that says "this branch has no conflicts with the base branch", you will see a message about the checks. When the Agda action successfully typechecks the code, that will turn green indicating that It is a good idea to require this check to pass for all pull requests to prevent accidentally merging broken code into Finally, this workflow doesn't work if the author of the PR created a new module and forgot to add it to |
Thanks. All new modules should be added to index.lagda unless they are unsafe. We want unsafe modules for limited purposes only (such as showing that type-in-type leads to a contradiction, or working with Brouwerian axioms in a non-standard way by disabling the termination checker (a better way is to work with axioms, given as module or function parameters)). |
Also, there are some lone modules which are deliberately not imported because they depend on the evolving cubical library, which is a moving target at the moment. I wonder how we could check them. An example is |
My Agda action actually downloads |
As I said, the cubical library is a moving target at the moment. If you look at the file mentioned above, you will see some comments explaining what to change depending one whether one uses the released version or the current version under development. |
Ah I see what you mean now. Sure, let's leave it like this for now. |
This PR fixes #43.
I have added subsingleton combinators as discussed in #43. Because different combinators require different assumptions, I have separated these into their own submodules. To give an example:
It will usually be the case that all of these will be imported, so I also added a submodule called
AllCombinators
(that dependends on both propositional truncation and function extensionality) and imports all of these submodules.