Is the assignment operation is redundant？

[liyangorg]

ldd3/scull/main.c

Line 607 in bdf0647

dev->cdev.ops = &scull_fops;

Hi, martinezjavier.

The assignment operation: "dev->cdev.ops = &scull_fops;", already included in function cdev_init, whether in v2.6.12 or in v5.1-rc4.

so, the assignment is redundant?

The following code is taken from :
https://github.com/torvalds/linux/blob/master/fs/char_dev.c
v5.1-rc4

/**
 * cdev_init() - initialize a cdev structure
 * @cdev: the structure to initialize
 * @fops: the file_operations for this device
 *
 * Initializes @cdev, remembering @fops, making it ready to add to the
 * system with cdev_add().
 */
void cdev_init(struct cdev *cdev, const struct file_operations *fops)
{
	memset(cdev, 0, sizeof *cdev);
	INIT_LIST_HEAD(&cdev->list);
	kobject_init(&cdev->kobj, &ktype_cdev_default);
	cdev->ops = fops;
}

[dwalkes]

so, the assignment is redundant?

I believe so! Fixed in #48