propagate relabelling for gabriel weights #35
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
This solves the test bench for the Delaunay-based graphs, in the sense that ids are retained and keept aligned with the input dataframe. Everything prints the same:
this is what I mean about "sorting by default." I don't think that, if the user provides
ids='FIPS'
, we should silently return a mis-aligned weights object fromfrom_dataframe()
. We can do this independently of the parentW
class.