-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for generating multiple css files: per-var initial state, rem… #8
Conversation
…oved :init fn from garden pool
@martinklepsch I'm not clear on how you are expecting :init to shave a few seconds off the build cycle, but from your comment it sounds like you want the init function to be called only once for any number of invocations of the garden task. This is not what is happening. Each time the boot garden task is called, it calls (garden-pool). This means that if you call the boot garden task twice and the :init option is retained, it will call that :init function twice. The exception occurs on the second call to the :init function. |
@mecha1 Every time the For details see the Have you not observed any differences in cycle times? |
@martinklepsch I think there is a discrepancy with the way we are expecting I was originally expecting that the The other issue is that if you are doing two invocations of the
it will create the pods and call the |
@martinklepsch hmm, ok maybe it was only my misunderstanding. I was expecting boot to reuse pods in the pool, but that is not what it does. It initializes pods (using The issue with boot-garden then looks like that it is creating a new pod-pool for each invocation of the garden task. I changed this to a single global garden pod pool and can now avoid the exception in #7 while still keeping the |
This makes perfect sense. Thank you. Would you still consider the exception to be a problem with Boot? If you feel like it a minimal repro would be awesome to file a bug against Boot so we can fix it there :) Seems like the base problem is creating two pod pools with two invocations of the same task. |
Ok, I'll put something together. Another thing I noticed is that the using |
…oved :init fn from garden pool