Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Atom parsing #104

Closed
Cj-Malone opened this issue Mar 13, 2017 · 2 comments
Closed

Atom parsing #104

Cj-Malone opened this issue Mar 13, 2017 · 2 comments
Assignees
@martinrotter
Labels
Component-Core Status-Fixed Ticket is resolved. Type-Enhancement This is request for brand new feature.
Milestone
3.4.1

Comments

@Cj-Malone
Copy link

You seem to prioritise summary over content. I think that should be the other way around.

The last link (that isn't rel=enclosure) is set as the URL, really that should be picking a link with rel=alternate (or null as alternate is default) and if there is multiple rel=alternate it should be the type=text/html

If the feed > entry > author is null you should fall back on feed > author, note there can be multiple authors so you should also be appending them.
@martinrotter
Copy link
Owner

That parsing is rather basic. This is all true, you wrote. :) I will enhance it hopefully soon. Maybe you can create some PR?

@martinrotter martinrotter self-assigned this Mar 14, 2017
@martinrotter martinrotter added Component-Core Status-Accepted I will eventually implement this. Type-Enhancement This is request for brand new feature. labels Mar 14, 2017
@martinrotter
Copy link
Owner

Fixed with 95a5831.

@martinrotter martinrotter added Status-Fixed Ticket is resolved. and removed Status-Accepted I will eventually implement this. labels Mar 26, 2017
@martinrotter martinrotter added this to the 3.4.1 milestone Mar 26, 2017
martinrotter added a commit that referenced this issue Apr 11, 2017
@martinrotter
Fixed #109 and made better RSS parser - fixed #104.
ec9e642
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martinrotter martinrotter

Labels
Component-Core Status-Fixed Ticket is resolved. Type-Enhancement This is request for brand new feature.
Projects
None yet
Milestone
3.4.1
Development

No branches or pull requests
2 participants
@martinrotter @Cj-Malone