Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User interface #6

Merged
merged 7 commits into from
Oct 22, 2021
Merged

User interface #6

merged 7 commits into from
Oct 22, 2021

Conversation

fzizzle
Copy link
Contributor

@fzizzle fzizzle commented Oct 18, 2021

No description provided.

@fzizzle
Initial Draft of GUI
658c8c5 
Rough draft of gui, not functional at the moment.
@fzizzle
Organising Folder
0184b05
@fzizzle
Merge branch 'main' into user-interface
c462d73
@fzizzle
Updated GUI
c134e93 
Added a class allowing updates and to track self.  Added export to JSON. Extra buttons to clear and store inputs to the script.
martinstarkov
martinstarkov requested changes Oct 20, 2021
View reviewed changes
Copy link
Owner

@martinstarkov martinstarkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename inputBox to InputBox (classes capitalized in python)

martinstarkov
martinstarkov requested changes Oct 20, 2021
View reviewed changes
Copy link
Owner

@martinstarkov martinstarkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename the JSON variables to be lower case with underscores (same as python convention) for consistency.

@martinstarkov
Copy link
Owner

martinstarkov commented Oct 20, 2021 •
edited
Loading

Other than that looks good! Great work!

martinstarkov
martinstarkov requested changes Oct 20, 2021
View reviewed changes
Copy link
Owner

@martinstarkov martinstarkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 38 (I believe) where you create an InputBox requires capitalizing still I believe.

@martinstarkov martinstarkov mentioned this pull request Oct 20, 2021
Closed
@martinstarkov martinstarkov merged commit d276e86 into martinstarkov:main Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinstarkov martinstarkov martinstarkov requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fzizzle @martinstarkov