Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Python 3.x #127

Merged
merged 1 commit into from
Jan 1, 2018
Merged

Use Python 3.x #127

merged 1 commit into from
Jan 1, 2018

Conversation

MikeBishop
Copy link
Contributor

Python 3.x is the default installed on Ubuntu going forward, but you're installing the 2.x binaries on the Docker image. Since I don't have 2.x and your Docker image doesn't have 3.x, there's no Python linting script I can sort out that will run on both a current default Ubuntu install and on your Circle images.

Can we bring your image up-to-date? That seems the easiest path out.

@martinthomson martinthomson merged commit 45fab27 into martinthomson:master Jan 1, 2018
martinthomson added a commit that referenced this pull request Jan 1, 2018
This reverts commit 45fab27, reversing
changes made to 6513a2d.
@martinthomson
Copy link
Owner

Hi Mike, I had a revert this. The problem with this is that the most recent xml2rfc release still doesn't work with python3.

@jimsch
Copy link
Contributor

jimsch commented Jan 1, 2018

It should work w/ python3 - what version are you using? I have it running on my laptop w/ 3.6

@martinthomson
Copy link
Owner

martinthomson commented Jan 2, 2018

@jimsch: this build fails: https://circleci.com/gh/quicwg/base-drafts/3856?utm_campaign=build-failed&utm_medium=email&utm_source=notification This would have used whatever was in pypi shortly after I merged this PR.

@jimsch
Copy link
Contributor

jimsch commented Jan 2, 2018

@martinthomson python does not believe that you have a real utf-8 source file. This is a difference between the v3 and v2 code in xml2rfc. I cannot tell you what the invalid character is, but you do have a position in the file. This is an input problem and not an xml2rfc problem per say. V2 read it as a binary ascii file and did not care if everything was a legal utf-8 character or not. I am going to guess it is an md problem, but I don't know w/o having the actual file.

@jimsch
Copy link
Contributor

jimsch commented Jan 2, 2018

I think I have changed my mind. It is an xml2rfc bug and I will log it.

@martinthomson
Copy link
Owner

@jimsch, I know what the problem is, it's kramdown-rfc2629 adding smart quotes. Thanks for logging the bug.

@jimsch
Copy link
Contributor

jimsch commented Jan 2, 2018

Yes, but it should have been accepted by xml2rfc and processed correctly. Currently it will not accept any input file which is not ascii even though it is supposed to. I have a local fix that I will be sending in to deal with this.

@MikeBishop
Copy link
Contributor Author

So shall we reopen/refresh this PR and hold it until the xml2rfc fix is in?

@martinthomson
Copy link
Owner

Yeah, I'll make sure the change is made once I can confirm that xml2rfc works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants