Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to suppress unstable warnings at run-time? #39

Closed
tueda opened this issue Aug 8, 2020 · 3 comments
Closed

Option to suppress unstable warnings at run-time? #39

tueda opened this issue Aug 8, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@tueda
Copy link

tueda commented Aug 8, 2020

Though it is a good thing to show warnings for unstable results (:wavy_dash: ... (Unstable with ...), sometimes one wants to run benchmarks in an environment where the execution is potentially perturbed by other processes and so results are known to be unstable; for example, in continuous integration.

So, it might be handy if an environment variable (NANOBENCH_NO_UNSTABLE_WARNING or something) could change the behaviour and suppress warnings for unstable results.

Changing the behaviour by a command-line option could be an alternative way, but I think an environment variable is more suitable for CI, and I guess it is easier to implement.

@martinus
Copy link
Owner

martinus commented Aug 8, 2020

Sounds like a good idea. I think I'll add an environment variable NANOBENCH_SUPPRESS_WARNINGS to do this and also suppress the other warnings like for frequency scaling

@martinus martinus self-assigned this Aug 12, 2020
@martinus martinus added the enhancement New feature or request label Aug 12, 2020
@martinus
Copy link
Owner

Fixed in dd25c03, see https://nanobench.ankerl.com/reference.html#nanobench-suppress-warnings-no-stability-warnings

tueda added a commit to tueda/tinymt-cpp that referenced this issue Aug 13, 2020
@tueda
Copy link
Author

tueda commented Aug 13, 2020

It perfectly works. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants