Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Add a revset for heads of other local workspaces #3384

Closed
Zoybean opened this issue Mar 28, 2024 · 2 comments
Closed

FR: Add a revset for heads of other local workspaces #3384

Zoybean opened this issue Mar 28, 2024 · 2 comments
Labels
good first issue Good for newcomers

Comments

@Zoybean
Copy link

Zoybean commented Mar 28, 2024

Is your feature request related to a problem? Please describe.
I do not use workspaces (yet), but I expect that if I did, I might like for a workspace's working-copy commit to be immutable from other workspaces, as I know that editing the head of one workspace from another will cause that workspace's copy to become stale, requiring a manual step to re-sync. This seems like something I'd prefer to avoid (though maybe it is not as much an issue as I am expecting).

The only barrier to me making them immutable, is the lack of a revset referring to those commits, as I know I can configure immutable_heads() myself.

Describe the solution you'd like
Define a revset, e.g. workspace_working_copy() that refers to the working-copy commits of any workspaces, or foreign_working_copy() for the working-copy commits of other workspaces. (Adding one would allow configuring an alias for the other)

Describe alternatives you've considered
None

Additional context
I'm very new to jj. Maybe this feature is needless, or already exists in some form.

@yuja
Copy link
Collaborator

yuja commented Mar 28, 2024

Templater has working_copies, but apparently revset doesn't. It should be easy to add the one.

@yuja yuja added the good first issue Good for newcomers label Mar 28, 2024
ckoehler added a commit to ckoehler/jj that referenced this issue Apr 1, 2024
It includes the working copy of every workspace of the repo.

Implements martinvonz#3384
ckoehler added a commit to ckoehler/jj that referenced this issue Apr 1, 2024
It includes the working copy of every workspace of the repo.

Implements martinvonz#3384
ckoehler added a commit to ckoehler/jj that referenced this issue Apr 1, 2024
It includes the working copy commit of every workspace of the repo.

Implements martinvonz#3384
ckoehler added a commit to ckoehler/jj that referenced this issue Apr 1, 2024
It includes the working copy commit of every workspace of the repo.

Implements martinvonz#3384
ckoehler added a commit to ckoehler/jj that referenced this issue Apr 1, 2024
It includes the working copy commit of every workspace of the repo.

Implements martinvonz#3384
ckoehler added a commit to ckoehler/jj that referenced this issue Apr 1, 2024
It includes the working copy commit of every workspace of the repo.

Implements martinvonz#3384
ckoehler added a commit to ckoehler/jj that referenced this issue Apr 1, 2024
It includes the working copy commit of every workspace of the repo.

Implements martinvonz#3384
ckoehler added a commit to ckoehler/jj that referenced this issue Apr 1, 2024
It includes the working copy commit of every workspace of the repo.

Implements martinvonz#3384
ckoehler added a commit to ckoehler/jj that referenced this issue Apr 1, 2024
It includes the working copy commit of every workspace of the repo.

Implements martinvonz#3384
ckoehler added a commit to ckoehler/jj that referenced this issue Apr 2, 2024
It includes the working copy commit of every workspace of the repo.

Implements martinvonz#3384
ckoehler added a commit to ckoehler/jj that referenced this issue Apr 2, 2024
It includes the working copy commit of every workspace of the repo.

Implements martinvonz#3384
ckoehler added a commit that referenced this issue Apr 2, 2024
It includes the working copy commit of every workspace of the repo.

Implements #3384
@ckoehler
Copy link
Collaborator

ckoehler commented Apr 2, 2024

Implemented by 7bde6dd

@ckoehler ckoehler closed this as completed Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants