cli: add a command for listing git remotes and their URLs #244
Conversation
| let workspace_command = command.workspace_helper(ui)?; | ||
| let repo = workspace_command.repo(); | ||
| let git_repo = get_git_repo(repo.store())?; | ||
| for remote_name in git_repo.remotes()?.iter().flatten() { |
There was a problem hiding this comment.
Why is flatten() needed here?
There was a problem hiding this comment.
Because the iterator before it yields Option<&str>, so this flatten() skips the empty values. I had actually initially written it as an if let Some(...) but then this Clippy lint told me to change to flatten(). I also find it unclear, but maybe we'll prefer it after we've been exposed to it a bit? Or we can disable that Clippy lint if you prefer (it would be the first one we disable).
| pub mod common; | ||
|
|
||
| #[test] | ||
| fn test_git_remotes() { |
There was a problem hiding this comment.
I think that can only happen if the URl is not valid UTF-8 and the libgit2 API doesn't seem to let us set such a URL (it takes a &str). I even tried to make this test write directly to .jj/repo/store/git/config but libgit2 apparently can't even open the repo if the config file has (or at least the URL?) has invalid UTF-8. So I guess we'll have to do without the test for now.
As requested by @talpr. I added this is a separate new command
jj git remote list. One could also imagine showing the listing when there isno sub-command specified to
jj git remote, but we don't have othercommands that behave that way yet.
Closes #243
Checklist
CHANGELOG.md