Add global --quiet flag to suppress non-primary output
#3401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinvonz
force-pushed
the
push-qwwlkuwzzosl
branch
from
e4f0ce8
to
4d85bf2
Compare
PhilipMetzger
approved these changes
Mar 30, 2024
yuja
approved these changes
Mar 31, 2024
martinvonz
force-pushed
the
push-qwwlkuwzzosl
branch
2 times, most recently
from
4c2da99
to
118e7db
Compare
4 tasks
martinvonz
force-pushed
the
push-qwwlkuwzzosl
branch
3 times, most recently
from
b0696ff
to
08bee8a
Compare
|
I had forgotten to update the setting in |
yuja
approved these changes
Apr 1, 2024
This clarifies that status messages are not errors, and allows us to implement a global `--quiet` flag for silencing status messages.
I'm about to make hints not get printed with `--quiet`, but error hints are probably still useful to get. They shouldn't be a problem for scripts since the script would have to deal with the error anyway.
When the caller needs a formatter, it's because they're doing something non-trivial. When the user passed `--quiet` (see upcoming patch), we should ideally skip doing related work for print the formatting output. It helps if the `Ui` object doesn't even return a `Formatter` then, so the caller is forced to handle the quiet case differently. Thanks to Yuya for the suggestion.
Same reasoning as the previous patch: we can avoid doing work when `--quiet` is passed.
martinvonz
force-pushed
the
push-qwwlkuwzzosl
branch
from
08bee8a
to
c2d2d5b
Compare
Note that `jj resolve` already had its own `--quiet` flag. The output with `--quiet` for that command got a lot quieter with the global `--quiet` also taking effect. That seems reasonable to me.
martinvonz
force-pushed
the
push-qwwlkuwzzosl
branch
from
c2d2d5b
to
6b3c7a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md