Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd squash: alias --to for the --into flag #3421

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Conversation

ilyagr
Copy link
Collaborator

@ilyagr ilyagr commented Apr 2, 2024

I keep typing --to since I'm used to jj move interface. It is also shorter.

Currently, if I type --to, clap unhelpfully suggests whether I
meant --tool.

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

Copy link

google-cla bot commented Apr 2, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ilyagr
Copy link
Collaborator Author

ilyagr commented Apr 2, 2024

CLA signed.

@ilyagr ilyagr marked this pull request as ready for review April 2, 2024 17:54
Copy link
Collaborator

@bnjmnt4n bnjmnt4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've been typing --to a lot as well.

I keep typing `--to` since I'm used to `jj move` interface. It is
also shorter.

Currently, if I type `--to`, clap unhelpfully suggests whether I
meant `--tool`.
@ilyagr
Copy link
Collaborator Author

ilyagr commented Apr 3, 2024

Thank you, Benjamin!

Thanks also, @martinvonz, for actually implementing the squashing of move and squash!

@ilyagr ilyagr merged commit 670e6ac into martinvonz:main Apr 3, 2024
16 checks passed
@ilyagr ilyagr deleted the moveto branch April 3, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants