-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rebase: rewrite rebase_revision
to use transform_descendants
#3551
Conversation
To fix the failing tests, you'll probably just need to do something similar to what I did in fe57602 |
Oh, this is of course instead related to what you asked about on discord, i.e. that |
46167d7
to
69cdf65
Compare
69cdf65
to
cc677ec
Compare
I will be updating `rebase -r` to avoid simplifying ancestor merges in a subsequent commit, which will cause existing tests to fail for the Git backend due to ancestor merges with the root commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for cleaning up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
Checklist
If applicable:
CHANGELOG.md