Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: refactor formatter selection #3668

Merged
merged 4 commits into from
May 12, 2024
Merged

ui: refactor formatter selection #3668

merged 4 commits into from
May 12, 2024

Commits on May 11, 2024

  1. ui: add helper function that sets up FormatterFactory 

    I'm going to split FormatterFactory::prepare() which takes 3 bool arguments,
and prepare() will be inlined there.
    @yuja
    yuja committed May 11, 2024
    Configuration menu
    Copy the full SHA
    e792bfd View commit details
    Browse the repository at this point in the history

  2. ui: forward .color() to FormatterFactory 

    This helps eliminate use_color() function.
    @yuja
    yuja committed May 11, 2024
    Configuration menu
    Copy the full SHA
    debb3bb View commit details
    Browse the repository at this point in the history

  3. ui: inline debug_color() and use_color()

    @yuja
    yuja committed May 11, 2024
    Configuration menu
    Copy the full SHA
    4e722c5 View commit details
    Browse the repository at this point in the history

  4. ui: add per-type FormatterFactory constructors, inline selection 

    This should be better than passing (bool, bool, bool) arguments.
    @yuja
    yuja committed May 11, 2024
    Configuration menu
    Copy the full SHA
    6e205ea View commit details
    Browse the repository at this point in the history