FR: register for watchman trigger #3862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arxanas
reviewed
Jun 13, 2024
fowles
force-pushed
the
main
branch
5 times, most recently
from
3cd0767
to
58f60e1
Compare
|
I have packed this into a single commit and internalized the extensions required to watchman, so I believe this is ready for final review. I still don't know how to unit test it. |
|
Small thing here, if you enable this it will probably break Optional: Change the commit title from |
arxanas
approved these changes
Jun 15, 2024
fowles
force-pushed
the
main
branch
2 times, most recently
from
fb4718a
to
89e044d
Compare
yuja
reviewed
Jun 16, 2024
fowles
force-pushed
the
main
branch
3 times, most recently
from
120ea51
to
19c8e9b
Compare
- make an internal set of watchman extensions until the client api gets updates with triggers - add a config option to enable using triggers in watchman Co-authored-by: Waleed Khan <me@waleedkhan.name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
facebook/watchman#1221
I have not done anything in the checklist yet, just offering this for early review.
Checklist
If applicable:
CHANGELOG.md