Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli internals: split jj git subcommand into separate files #3896

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

fowles
Copy link
Collaborator

@fowles fowles commented Jun 16, 2024

No description provided.

@yuja
Copy link
Collaborator

yuja commented Jun 17, 2024

I vote against this move, but I don't have strong feeling. If people agree, I'm file with this change.

BTW, we can also inline mod add { .. }, etc. if we want to make them structured as sub-sub modules without creating too many micro files.

@martinvonz
Copy link
Owner

I vote against this move, but I don't have strong feeling.

Why are you against it?

Which editor do you use? I'm curious if the choice of editor impacts a person's preference here. I use VS Code which makes it quite easy to open a file by name or by contents. Maybe that's harder with some editors (it certainly is for me when using Emacs or Vim but that's probably mostly because I've never bothered to learn either of them).

@yuja
Copy link
Collaborator

yuja commented Jun 17, 2024

Which editor do you use?

Emacs ;)

I'm curious if the choice of editor impacts a person's preference here.

Yeah, that's probably it. I personally find it's easier to read/search/edit in one file of reasonable size than opening multiple small related files. That's the same reason that editing multiple commit descriptions in one buffer is easier.

@fowles fowles changed the title Split git remote subcommand into separate files cli internals: split git remote subcommand into separate files Jun 17, 2024
Moved commands are `git clone`, `git export`, `git fetch`, `git import`,
`git init`, `git push`, `git remote`, and `git submodule`.
@fowles fowles changed the title cli internals: split git remote subcommand into separate files cli internals: split jj git subcommand into separate files Jun 18, 2024
Copy link
Owner

@martinvonz martinvonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quoting @yuja:

I vote against this move, but I don't have strong feeling. If people agree, I'm file with this change.

It sounded on Discord like no one has really strong opinions. There we were more people for than against, so I think we should merge this.

For the record, @fowles and I work for the same company, but I'll approve this anyway since it seems clearly not specific to Google's interests.

@fowles fowles merged commit 2364cf2 into martinvonz:main Jun 18, 2024
17 checks passed
@fowles fowles deleted the git_sub branch June 19, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants