watchman: switch from a private extension to the newly release 0.9.0

[fowles]

No description provided.

[thoughtpolice]

Note that this will break both:

• The Nix build (which will require a change to cargoLock.outputHashes, so it's fixable at least).[1] But more importantly,
• Publishing to crates.io, because it does not allow a crate to have unpublished dependencies (unfixable).

So, this will probably have to go on hold/draft until a new watchman_client is released anyway, I'm afraid, which is why I'm giving it a -1 (really, the only reason). Otherwise it LGTM. You may already be aware of that of course, but I'm writing it here for anyone else coming by. :)

Is there anything particularly wrong with using the current code path? Or is the main advantage just being able to delete some code? We can have a TODO or bug assigned for that, at least.

[1] And even though it's fixable, I'd really prefer we didn't do it anyway, because in practice, at least IME, if people ever need to readjust it or fix it again, they may have no idea how to do so if they aren't familiar with Nix and have it installed. I think that's a pretty poor experience for most of us (spoken as the main developer using it — in general, I'm quite happy that our Nix builds have very little overhead for the main workflows.)

[fowles]

@thoughtpolice Given that the client had not had.a new version for 2 years, I was worried that they wouldn't spin one soon. But I filled an issue and they released 0.9.0 earlier today. So I have updated this to work on the released version. :)

The requested change has been made.

[thoughtpolice]

Given that the client had not had.a new version for 2 years, I was worried that they wouldn't spin one soon.

Makes sense, thanks!