-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: branch: make "set" do upsert as before #3932
Conversation
Hmm, when I read this PR title (having forgotten about the previous discussion), I thought that |
Hmm, I thought |
I'm wondering whether we should just be more aggressive here and let For example, for a release or two, we can print a warning when I also agree with #3932 (comment), |
Perhaps I'm not following what your plan is. I guess my concern is that if we merely create the option now and make it the default later, then it feels like the change would be just as breaking at that later point as it would be now if we made the change without the option. What is the option's purpose in your mind? |
My plan was:
That sounds also good, and I like the idea.
Okay, there are two votes, so let's rename then. |
Since "set <thing>" often adds a <thing> if not exists, it make some sense that "branch set" does upsert. The current "branch set" use case is now covered by "branch move", so it's okay to change the "set" behavior. If new branch is created by "branch set", status message and hint will be printed to help migration. The user should be able to undo creation if it was a mistake. Closes martinvonz#3584
Implemented this as it seemed simpler. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you!
#3584
Checklist
If applicable:
CHANGELOG.md