Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add homebrew on Linux and macOS #439

Merged
merged 2 commits into from
Oct 18, 2022

Conversation

ClashTheBunny
Copy link
Collaborator

This adds directions that will work when
Homebrew/homebrew-core#105986 is merged. If that is
not merged, we can create a tap and adjust these directions accordingly.

I think I followed the current formatting, but is there a specific markdown linting that is preferred? I didn't see anything in the .github directory.

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)

README.md Outdated Show resolved Hide resolved
This adds directions that will work when
Homebrew/homebrew-core#105986 is merged.  If that is
not merged, we can create a tap and adjust these directions accordingly.
@ClashTheBunny
Copy link
Collaborator Author

This is merged in homebrew and I've used it to install 0.4.0 and head in homebrew.

https://formulae.brew.sh/formula/jj#default and https://github.com/Homebrew/homebrew-core/blob/master/Formula/jj.rb look correct and there are bottles created for them on pretty much every OS.

Should I add something like "we don't release very often, so it may be more interesting to install the --HEAD version."?

@martinvonz
Copy link
Owner

This is merged in homebrew and I've used it to install 0.4.0 and head in homebrew.

Thanks! Does that mean that this is now ready for review?

Should I add something like "we don't release very often, so it may be more interesting to install the --HEAD version."?

It just hasn't seemed like it mattered much when I cut release because most people build from head so far, but I'm happy to cut releases more frequently instead of telling people to build from head.

@ClashTheBunny ClashTheBunny marked this pull request as ready for review October 17, 2022 23:26
@ClashTheBunny
Copy link
Collaborator Author

ClashTheBunny commented Oct 17, 2022

It just hasn't seemed like it mattered much when I cut release because most people build from head so far, but I'm happy to cut releases more frequently instead of telling people to build from head.

I'd say we keep an eye on jj installs and if there seem to be a bunch from the release, we can cut releases more often. I'm actually amazed there have been 23 installs in the last 30 days...

@martinvonz
Copy link
Owner

I'd say we keep an eye on jj installs and if there seem to be a bunch from the release, we can cut releases more often. I'm actually amazed there have been 23 installs in the last 30 days...

Sounds good. I'll still cut a release now because it's been so long. Looks like I should send a PR to update that jj.rb file once that's out. Thanks again for setting this up!

@martinvonz
Copy link
Owner

Actually, we should add a --bin jj to https://github.com/Homebrew/homebrew-core/blob/5e9c402aa309f6ea49fb7283b91effc2cbb96a95/Formula/jj.rb#L27 to avoid installing fake-editor and fake-diff-editor (until a good alternative to #216 has been merged). Sorry that I didn't notice that until now.

@ClashTheBunny ClashTheBunny merged commit f6dd251 into martinvonz:main Oct 18, 2022
@ClashTheBunny
Copy link
Collaborator Author

When you cut the release, we can try brew bump:

❯ brew bump jj
==> jj
Current formula version:  0.4.0
Latest livecheck version: 0.4.0
Latest Repology version:  no latest version
Open pull requests:       none

and then it will create the PR: https://docs.brew.sh/How-To-Open-a-Homebrew-Pull-Request#submit-a-new-version-of-an-existing-formula

@martinvonz
Copy link
Owner

When you cut the release, we can try brew bump:

Thanks, will do.

ClashTheBunny added a commit to ClashTheBunny/homebrew-core that referenced this pull request Oct 18, 2022
Currently there are a few test binaries that are produced with the cargo
build, this prevents all but jj from being installed.
martinvonz/jj#439 (comment)
BrewTestBot pushed a commit to Homebrew/homebrew-core that referenced this pull request Oct 18, 2022
Currently there are a few test binaries that are produced with the cargo
build, this prevents all but jj from being installed.
martinvonz/jj#439 (comment)

Closes #113367.

Signed-off-by: Sean Molenaar <1484494+SMillerDev@users.noreply.github.com>
Signed-off-by: BrewTestBot <1589480+BrewTestBot@users.noreply.github.com>
@ClashTheBunny
Copy link
Collaborator Author

Okay, brew bumped also:
Homebrew/homebrew-core#113411

brew bump --open-pr jj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants