-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add homebrew on Linux and macOS #439
Add homebrew on Linux and macOS #439
Conversation
This adds directions that will work when Homebrew/homebrew-core#105986 is merged. If that is not merged, we can create a tap and adjust these directions accordingly.
fec8e7a
to
6615c57
Compare
This is merged in homebrew and I've used it to install 0.4.0 and head in homebrew. https://formulae.brew.sh/formula/jj#default and https://github.com/Homebrew/homebrew-core/blob/master/Formula/jj.rb look correct and there are bottles created for them on pretty much every OS. Should I add something like "we don't release very often, so it may be more interesting to install the |
Thanks! Does that mean that this is now ready for review?
It just hasn't seemed like it mattered much when I cut release because most people build from head so far, but I'm happy to cut releases more frequently instead of telling people to build from head. |
I'd say we keep an eye on jj installs and if there seem to be a bunch from the release, we can cut releases more often. I'm actually amazed there have been 23 installs in the last 30 days... |
Sounds good. I'll still cut a release now because it's been so long. Looks like I should send a PR to update that |
Actually, we should add a |
When you cut the release, we can try brew bump:
and then it will create the PR: https://docs.brew.sh/How-To-Open-a-Homebrew-Pull-Request#submit-a-new-version-of-an-existing-formula |
Thanks, will do. |
Currently there are a few test binaries that are produced with the cargo build, this prevents all but jj from being installed. martinvonz/jj#439 (comment)
Currently there are a few test binaries that are produced with the cargo build, this prevents all but jj from being installed. martinvonz/jj#439 (comment) Closes #113367. Signed-off-by: Sean Molenaar <1484494+SMillerDev@users.noreply.github.com> Signed-off-by: BrewTestBot <1589480+BrewTestBot@users.noreply.github.com>
Okay, brew bumped also:
|
This adds directions that will work when
Homebrew/homebrew-core#105986 is merged. If that is
not merged, we can create a tap and adjust these directions accordingly.
I think I followed the current formatting, but is there a specific markdown linting that is preferred? I didn't see anything in the
.github
directory.Checklist
If applicable:
CHANGELOG.md