Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to PM 31.0 #8

Closed
3 tasks done
martok opened this issue Mar 17, 2022 · 11 comments
Closed
3 tasks done

Update to PM 31.0 #8

martok opened this issue Mar 17, 2022 · 11 comments
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@martok
Copy link
Owner

martok commented Mar 17, 2022

  • have optional Firefox GUID. Should be no change from our side as native PM/SM addon?
  • queueMicrotask is implemented, remove polyfill
  • optchaining implemented, remove scriptfixes (only ?., nullish coalescing ?? is implemented in upstream UXP, should be in next release)
@martok martok changed the title Update to PM 30.0 Update to PM 31.0 May 10, 2022
@martok martok added help wanted Extra attention is needed question Further information is requested labels May 10, 2022
@martok
Copy link
Owner Author

martok commented May 10, 2022

Help Wanted: someone with Seamonkey expertise, please clarify what that means for syntax hotpatching: do we need to carry the existing patches for the forseeable future?
I'd like to remove fixes not needed for Goanna, but don't want to break SM for no reason.

@martok
Copy link
Owner Author

martok commented May 13, 2022

Postponing until hopefully a 31.x point release: the removal of one too many e10s flags (see https://repo.palemoon.org/MoonchildProductions/Pale-Moon/commit/deaeb6874dfe19e69ea2915d206c690735072de4) broke many of my daily-use addons so I can't really upgrade to 31. It's been fixed upstream so it probably won't be too long...

@UCyborg
Copy link
Contributor

UCyborg commented May 19, 2022

I wouldn't call myself SeaMonkey expert, but nothing new in the current stable version as far as new JavaScript syntax is concerned. If you think it'll speed anything up for Goanna, maybe wrap optional chaining patches in if (service.isSeaMonkey).

You can also probably remove the fix for Stack Exchange. I imagine if the issue pops up again, it'll be in some other place...few days ago optional chaining appeared inline of HTML of Stack Overflow website specifically, then disappeared at later point.

@martok
Copy link
Owner Author

martok commented May 27, 2022

Thanks.
That actually gives me an idea, the new rule tree architecture is flexible and fast enough that I can just split the rule scripts in a generic and UA-specific one and decide at runtime which one to load and merge. No UA gates required in code then.

UXP has gotten Franklin's ?? implementation as well, so that'd be another load of fixes out for the next release. Which, with my luck, will be released right after I extend this addon to switch based on PM30/31+ :D

@martok
Copy link
Owner Author

martok commented May 31, 2022

Released 1.10 with PM31 support. Still need to clean up the required fixes... I have a good concept for how to do that with the different supported platforms now, just need to find the time to sit down and implement it.

@ghost
Copy link

ghost commented Jun 1, 2022

It seems to work fine with Github on PM 31, but if I go to Gitlab it shows an endlessly spinning circle on the issues search box.

@l29ah
Copy link

l29ah commented Jun 1, 2022

It does not. File attachment functionality in the issue post/comment box doesn't work.

@martok
Copy link
Owner Author

martok commented Jun 1, 2022

@JAAnon @l29ah Please open a separate issue with steps to reproduce, works for me.
(Well, the Gitlab average of "works"... I'll never understand why people love them so much)

@l29ah
Copy link

l29ah commented Jun 1, 2022

I was talking about github.

@martok
Copy link
Owner Author

martok commented Jun 1, 2022

monkeys

Hm. Works here but it might be some interaction, I'll check with a blank profile tomorrow!

--
Update: nope, can't see any problem in a fresh portable install either.

@martok
Copy link
Owner Author

martok commented Jun 3, 2022

I have a good concept for how to do that with the different supported platforms now, just need to find the time to sit down and implement it.

Aaaand done. Let's see how future proof it is (and also, what odd bugs I introduced 😅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants