Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify note about where the plugin should go #224

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

seanparmelee
Copy link

Hello!

Regarding this note:

please declare withTM as your last plugin (the "most nested" one).

It may just be me, but my interpretation of this note is contradicting:

  • by "last plugin" i'm thinking the last plugin that should be applied i.e.
module.exports = withTM(
  withSomeOtherPlugin(
    withYetAnotherPlugin(
      {...} // actual next config
    )
  )
);
  • by "most nested" one, I'm thinking the opposite:
module.exports = withSomeOtherPlugin(
  withYetAnotherPlugin(
    withTM(
      {...} // actual next config
    )
  )
);

Assuming the first example is the right way, I wanted to propose a small change to the README that I think clarifies this up (or maybe we can add an example such as the one above to help clarify?).

@martpie
Copy link
Owner

martpie commented Jul 14, 2021

Thank you!

@martpie martpie merged commit 91b2413 into martpie:master Jul 14, 2021
@seanparmelee seanparmelee deleted the patch-1 branch July 15, 2021 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants