-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to Emoji 15.0 #18
Comments
Thanks for the report, that is really good input! I do not remember why I chose the hard-coded '14.0' emoji download link but we can definitely use And I think it is also a good point to extract the magic URL values somewhere to the top. I am still considering moving the whole downloading portion into a separate executable but this is a good first step to remove some 'magic' from it. I'll definitely get around to the changes but am also happy to merge a little PR if you're inclined! |
Point url to grab emoji from to latest version of emoji list, which should automatically point to upcoming versions as well. Fixes #18.
We are now getting the emoji from the new url on download on the dev branch. I have decided against moving the url variables to the top to make them less magical - each of the download routines itself is closely tied to the content at their respective links and it does not make too much sense to allow to change them. |
I miss the 🪿.
And maybe it makes sense to put URLs for both emojis and math symbols at the top as variables, so all hardcoded values are clearly visible and not buried in the code.
The text was updated successfully, but these errors were encountered: