Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert stack/stack.go to a formal state machine #2

Closed
wickedchicken opened this issue Apr 28, 2015 · 1 comment
Closed

convert stack/stack.go to a formal state machine #2

wickedchicken opened this issue Apr 28, 2015 · 1 comment

Comments

@wickedchicken
Copy link

See https://github.com/maruel/panicparse/blob/master/stack/stack.go#L272.
@maruel maruel assigned maruel and unassigned maruel May 8, 2015
@maruel
Copy link
Owner

maruel commented Dec 28, 2015

I clarified the loop a bit in 8852acb.

maruel added a commit that referenced this issue Mar 16, 2018
@maruel
stack: move local variables into a struct
e8e77c6 
Create a struct to hold parsing states. It's very far from a state machine but
that's a step in the right direction.

Addresses issue #2
maruel added a commit that referenced this issue Mar 16, 2018
@maruel
stack: migrate line parsing code into a function
3441ea3 
This makes the line parsing a bit easier to read. Still work to do.

No functional change.

Addresses issue #2
@maruel maruel mentioned this issue Sep 11, 2018
Closed
@maruel maruel closed this as completed in 6723201 May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wickedchicken @maruel