Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with current development version #32

Closed
wants to merge 1 commit into from
Closed

Conversation

AlekSi
Copy link
Contributor

@AlekSi AlekSi commented Aug 9, 2017

To catch errors early.

@coveralls
Copy link

coveralls commented Aug 9, 2017

Coverage Status

Coverage remained the same at 60.967% when pulling a631e78 on AlekSi:patch-1 into 868abbf on maruel:master.

@maruel
Copy link
Owner

maruel commented Aug 11, 2017

I pondered this (but I was using tip) but decided against as I prefer reproducible tests, and in this case it is impossible to reproduce a run like this.

There's value on both side but I feel 1.x is already giving the best value here.

@maruel
Copy link
Owner

maruel commented Aug 23, 2017

I'll close this PR as for now I don't want to have to manage inconsistent test executions, especially during the "development phase" of Go. See https://github.com/golang/go/wiki/Go-Release-Cycle#timeline for more details.

@maruel maruel closed this Aug 23, 2017
@AlekSi
Copy link
Contributor Author

AlekSi commented Aug 23, 2017

Well… Does it work with Go 1.9?

@maruel
Copy link
Owner

maruel commented Aug 23, 2017

I use go 1.9 rc2 locally. You made me realize I should update now, so I did but there no new release yet. (I always build golang from sources)

@maruel
Copy link
Owner

maruel commented Aug 23, 2017

and to be clear, master != release-branch.go1.9

@AlekSi AlekSi deleted the patch-1 branch August 23, 2017 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants