Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added go-recipes badge #83

Merged
merged 2 commits into from
Nov 12, 2022
Merged

Added go-recipes badge #83

merged 2 commits into from
Nov 12, 2022

Conversation

nikolaydubina
Copy link
Contributor

Hello, Hi!! 👋🏻

I like your project and I think broader Go community will benefit from it too.

Thus, I added it to the curated list of Go tools.

I hope this badge will serve as a mark of quality and appreciation to your project.

Once again, thank you for your work!!

❤️

-- Nikolay

@codecov
Copy link

codecov bot commented Nov 12, 2022

Codecov Report

Base: 83.4% // Head: 83.4% // No change to project coverage 👍

Coverage data is based on head (c1a9e07) compared to base (397044e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #83   +/-   ##
=====================================
  Coverage   83.4%   83.4%           
=====================================
  Files         12      12           
  Lines       2768    2768           
=====================================
  Hits        2308    2308           
  Misses       399     399           
  Partials      61      61           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Owner

@maruel maruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to admit initially I thought it was a spam PR. It doesn't happen often, but it occasionally does.

It's actually a pretty cool ressource! I like how you used a consistent form "title, two liners, one command, one screenshot/example block". It's a great doc writing style. Congrats.

README.md Outdated
@@ -6,6 +6,7 @@ process.

[![PkgGoDev](https://pkg.go.dev/badge/github.com/maruel/panicparse/v2/stack)](https://pkg.go.dev/github.com/maruel/panicparse/v2/stack)
[![codecov](https://codecov.io/gh/maruel/panicparse/branch/main/graph/badge.svg?token=izj1cLjUi3)](https://codecov.io/gh/maruel/panicparse)
[![go-recipes](https://raw.githubusercontent.com/nikolaydubina/go-recipes/main/badge.svg?raw=true)](https://github.com/nikolaydubina/go-recipes)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about linking to https://github.com/nikolaydubina/go-recipes#-pretty-print-panic-messages instead? The reason is that the user will get context aware context, and then can move incrementally (scroll up and down) from there to have related content, versus starting from the top and trying to find related content.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of course! good idea!

README.md Outdated Show resolved Hide resolved
@maruel maruel merged commit 75e99c0 into maruel:main Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants