Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation for Fish shell #88

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Fix documentation for Fish shell #88

merged 1 commit into from
Oct 5, 2023

Conversation

AlekSi
Copy link
Contributor

@AlekSi AlekSi commented Oct 5, 2023

No description provided.

@@ -48,7 +48,7 @@ panicparse helps make sense of Go crash dumps:
* Ubuntu (bash v4 or zsh): `|&`
* macOS, [install bash 4+](README.md#updating-bash-on-macos), then: `|&`
* Windows _or_ macOS with stock bash v3: `2>&1 |`
* [Fish](http://fishshell.com/) shell: `^|`
* [Fish](http://fishshell.com/) shell: `&|`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was just a typo

Comment on lines 77 to +78
**Fish**: `&|` redirects stderr and stdout. It's an alias for `2>&1 |`
([fish piping](https://fishshell.com/docs/current/index.html#piping)):
([fish piping](https://fishshell.com/docs/current/language.html#piping)):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The syntax there is correct, but the URL changed

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (a67acbb) 83.4% compared to head (8392be3) 83.4%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #88   +/-   ##
=====================================
  Coverage   83.4%   83.4%           
=====================================
  Files         12      12           
  Lines       2768    2768           
=====================================
  Hits        2308    2308           
  Misses       399     399           
  Partials      61      61           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@maruel maruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@maruel
Copy link
Owner

maruel commented Oct 5, 2023

I'll have to fix the linter later.

@maruel maruel merged commit 6854937 into maruel:main Oct 5, 2023
8 of 11 checks passed
@AlekSi AlekSi deleted the patch-1 branch October 5, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants