Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Controller Request Rspec test #5

Merged
merged 4 commits into from
Sep 25, 2023
Merged

Add Controller Request Rspec test #5

merged 4 commits into from
Sep 25, 2023

Conversation

marvin-nyalik
Copy link
Owner

In this branch:

  • I added RSpec as a gem to my project.
  • I created a Request spec file for the controllers (Posts, Users).
  • For each action in the controllers am checking:
    • If response status was correct.
    • If a correct template was rendered.
    • If the response body includes correct placeholder text.

Let me know in case changes are needed @marvin-nyalik

Copy link

@gemmen29 gemmen29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @marvin-nyalik,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights 💯

  • No linters errors ✔️
  • Descriptive pull request ✔️
  • Descriptive commit messages ✔️

Optional suggestions

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@marvin-nyalik marvin-nyalik merged commit 00e327d into dev Sep 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants