Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ignoring Pre-Releases #44

Open
amogus07 opened this issue Jul 24, 2024 · 5 comments · May be fixed by #49
Open

Allow ignoring Pre-Releases #44

amogus07 opened this issue Jul 24, 2024 · 5 comments · May be fixed by #49

Comments

@amogus07
Copy link

Right now, I use stew to keep the syncthing binary up-to-date. Today, stew upgrade --all updated it to v1.27.10-rc.1, which is a labeled as "Pre-Release". Is there a way to have stew only pull updates labeled as "Latest" and ignore Pre-Releases?

@marwanhawari
Copy link
Owner

I agree, the only time I would want to see prereleases are for the stew browse command. Everything else should just pull the latest non-prerelease release.

Looks like there is a boolean prerelease property returned in the HTTP response for the GitHub API GET /repos/{owner}/{repo}/releases endpoint. Would need to update this type and then update the application code to filter out prerelease releases (except for stew browse).

Do you want to try and take this on?

@amogus07
Copy link
Author

amogus07 commented Aug 2, 2024

I'm sorry, I would love to help out, but I don't know Go, neither am I familiar with this project's source code. As of now, someone else will have to do it.

@HugoDF
Copy link

HugoDF commented Oct 5, 2024

@marwanhawari if this is still of interest I can work on a Pull Request

@marwanhawari
Copy link
Owner

Yeah I'd be happy to review a PR!

@HugoDF
Copy link

HugoDF commented Oct 11, 2024

@marwanhawari PR is ready for review #49

I wonder if we should also be excluding draft releases? (unless something is doing that for us already)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants