Remove uses of ClassTemplateSpecializationDecl::getTypeAsWritten #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
The suggested change looks fine! However, it seems the additional changes to the renaming pass will be needed in order to fix the 2 failures spotted with LLVM 19. @sdkrystian Are you willing to work on that as part of this PR? |
|
@marxin I pushed a commit which should fix the failing tests |
sdkrystian
force-pushed
the
fix-type-as-written
branch
from
c66b4b8
to
66e932a
Compare
marxin
requested changes
May 29, 2024
sdkrystian
force-pushed
the
fix-type-as-written
branch
from
66e932a
to
8321d42
Compare
|
@marxin updated |
|
The current LLVM master seems promising, but we will likely need a conditional build for the existing releases. What do you think 🤔? |
marxin
added a commit
that referenced
this pull request
Jun 3, 2024
|
The CI should be happy after 16a34b2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #142