[WIP] API for probing a new path. #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nibanks
reviewed
Apr 14, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
masa-koz
commented
Apr 24, 2023
src/core/lookup.c
Outdated
| CxPlatListPopEntry(&CID->HashEntries), | ||
| QUIC_CID_HASH_ENTRY, | ||
| Link); | ||
| QuicLookupRemoveLocalCidInt(&CID1->Binding->Lookup, CID1); |
There was a problem hiding this comment.
Acquiring lock for this lookup is missing. But this function should be removed?
src/core/connection.h
Outdated
| CXPLAT_LIST_ENTRY Link; | ||
| QUIC_CONNECTION *Connection; | ||
| } QUIC_CONNECTION_LIST_ENTRY; | ||
|
|
There was a problem hiding this comment.
This struct not necessary.
masa-koz
commented
Apr 24, 2023
src/core/connection.c
Outdated
| CXPLAT_FREE(SourceCid, QUIC_POOL_CIDHASH); | ||
|
|
||
| BOOLEAN Collision = FALSE; | ||
|
|
There was a problem hiding this comment.
Acquiring MsQuicLib.DatapathLock is missing.
masa-koz
commented
Jun 29, 2023
| if (Entry1->Binding == Binding) { | ||
| QuicBindingRemoveSourceConnectionID(Binding, Entry1); | ||
| *Link1 = (*Link1)->Next; | ||
| CxPlatListPushEntry(&EntriesToFree, &Entry1->Link); |
src/core/connection.c
Outdated
Comment on lines
997
to
1001
| for (uint8_t i = 0; i < Connection->PathsCount; ++i) { | ||
| if (Connection->Paths[i].Binding != NULL) { | ||
| QuicBindingAddSourceConnectionID(Connection->Paths[i].Binding, SourceCid); | ||
| } | ||
| } |
There was a problem hiding this comment.
Shouldn't you move this to the insider of lock?
| @@ -6564,6 +6675,153 @@ QuicConnParamSet( | |||
| return QUIC_STATUS_SUCCESS; | |||
| } | |||
|
|
|||
| case QUIC_PARAM_CONN_ADD_LOCAL_ADDRESS: { | |||
There was a problem hiding this comment.
NEW_LOCAL_ADDRESS instead？
masa-koz
commented
Mar 24, 2024
| LocalAddress)) { | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
Check whether the local address already contains.
Comment on lines
+950
to
+956
| if (!Collision) { | ||
| for (uint8_t i = 0; i < Connection->PathsCount; ++i) { | ||
| if (Connection->Paths[i].Binding != NULL) { | ||
| QuicBindingAddSourceConnectionID(Connection->Paths[i].Binding, SourceCid); | ||
| } | ||
| } | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm trying to add an API for probing a new path (QUIC_PARAM_CONN_ADD_LOCAL_ADDRESS).
Testing
I've added a new test ("Basic/WithProbePathArgs.ProbePath/*").
Documentation
N/A