Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Q::Statement::My in favor of Q::Term::My #369

Merged
merged 1 commit into from
Aug 7, 2018
Merged

Conversation

masak
Copy link
Owner

@masak masak commented Aug 3, 2018

(Note: This PR builds atop #364, and shouldn't merge before it. Please allow this PR to refactor on top of a merged #364 before merging this one.) Rebased.

See #279 for reasons.

In the end this was a smaller change than I feared it would be. Having made it,
I'm also more convinced (despite initial misgivings) that it's a simpler model.

(In particular, it used to be that assignment semantics resided "inside" the
my statement semantics. Now it's all on the outside. The my term, at
runtime, is completely transparent and behaves exactly like the identifier it
declares.)

It also doesn't hurt that this simpler model is also somewhat richer than the
old one. :)

Closes #279.

@masak masak force-pushed the masak/my-term branch 3 times, most recently from 7e38560 to 5d904c7 Compare August 4, 2018 20:58
See #279 for reasons.

In the end this was a smaller change than I feared it would be. Having made it,
I'm also more convinced (despite initial misgivings) that it's a simpler model.

(In particular, it used to be that assignment semantics resided "inside" the
`my` statement semantics. Now it's all on the outside. The `my` term, at
runtime, is completely transparent and behaves exactly like the identifier it
declares.)

It also doesn't hurt that this simpler model is also somewhat richer than the
old one. :)

Closes #279.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants