Remove Q::Statement::My in favor of Q::Term::My #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masak
force-pushed
the
masak/my-term
branch
3 times, most recently
from
7e38560
to
5d904c7
Compare
See #279 for reasons. In the end this was a smaller change than I feared it would be. Having made it, I'm also more convinced (despite initial misgivings) that it's a simpler model. (In particular, it used to be that assignment semantics resided "inside" the `my` statement semantics. Now it's all on the outside. The `my` term, at runtime, is completely transparent and behaves exactly like the identifier it declares.) It also doesn't hurt that this simpler model is also somewhat richer than the old one. :) Closes #279.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Note: This PR builds atop #364, and shouldn't merge before it. Please allow this PR to refactor on top of a merged #364 before merging this one.)Rebased.See #279 for reasons.
In the end this was a smaller change than I feared it would be. Having made it,
I'm also more convinced (despite initial misgivings) that it's a simpler model.
(In particular, it used to be that assignment semantics resided "inside" the
mystatement semantics. Now it's all on the outside. Themyterm, atruntime, is completely transparent and behaves exactly like the identifier it
declares.)
It also doesn't hurt that this simpler model is also somewhat richer than the
old one. :)
Closes #279.