Implement infix:<div> operator #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Travis tests are failing because rakudobrew is issuing a warning. We should resolve that before merging this one. |
masak
force-pushed
the
masak/div-operator
branch
from
c8a9181
to
ca97ce0
Compare
|
Yay! TravisCI passes now! @claes-magnus, do you have time for a code review? |
ghost
reviewed
Apr 22, 2019
ghost
reviewed
Apr 22, 2019
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #493. (But see also previous discussion in #438 and #34.)
After landing this operator, there's a function
halfin boxify that I'd like to improve. I'll send a PR.