Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Tags related functionality #15

Merged
merged 5 commits into from
Oct 18, 2022
Merged

Added Tags related functionality #15

merged 5 commits into from
Oct 18, 2022

Conversation

pankajanand18
Copy link
Contributor

@pankajanand18 pankajanand18 commented Oct 18, 2022 •
edited
Loading

Tags

  • Added a new struct to parse Tags info from getInfo Api response.
  • Added a new function to Add Tags to an existing photo. Underlying it calls addTags
  • Added a test case for parsing the tags correctly.

Photos

  • One tiny fix to convert int to string using strconv.Itoa instead of string . It was causing runtests.sh to fail due to warning.

Sizes

  1. Added structure to define the response of flickr.photos.getSizes
  2. Added a new function to getSizes

Testing

  • Fixed the formatting of Error in error_test.go, it was causing the runtests.sh to fail.

masci
masci approved these changes Oct 18, 2022
View reviewed changes
Copy link
Owner

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@masci masci merged commit 2e651d3 into masci:v2 Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masci masci masci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pankajanand18 @masci