Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use matrix in workflows when possible with online license check #157

Conversation

masesdevelopers
Copy link
Contributor

Description

This PR adds online license check and try to use the matrix behavior of workflows when it is possible. Windows cannot do that because at the end of processing it is important to have a single update of the repository with all new reflection done.

Related Issue

closed #155

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@masesdevelopers masesdevelopers added enhancement New feature or request github_actions Pull requests that update GitHub Actions code labels Dec 4, 2023
@masesdevelopers masesdevelopers self-assigned this Dec 4, 2023
@masesdevelopers masesdevelopers changed the title Use matrix when possible with online license Use matrix in workflows when possible with online license check Dec 4, 2023
@masesdevelopers masesdevelopers merged commit c722edb into masesgroup:master Dec 4, 2023
6 checks passed
@masesdevelopers masesdevelopers deleted the 155-use-online-license-for-tests-instead-of-file-based-license branch December 4, 2023 21:01
masesdevelopers added a commit to masesdevelopers/JCOReflector that referenced this pull request Dec 4, 2023
masesdevelopers added a commit that referenced this pull request Dec 4, 2023
masesdevelopers added a commit to masesdevelopers/JCOReflector that referenced this pull request Dec 4, 2023
masesdevelopers added a commit that referenced this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use online license for tests instead of file based license
1 participant