Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed KNetProducer plus added new API on KNetProducer, fixed Dispose of KNetConsumer, reviewed KNetCompactedReplicator synchronization #220

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Fixed KNetProducer plus added new API on KNetProducer, fixed Dispose of KNetConsumer, reviewed KNetCompactedReplicator synchronization #220

merged 1 commit into from
Aug 28, 2023

Conversation

masesdevelopers
Copy link
Contributor

@masesdevelopers masesdevelopers commented Aug 28, 2023 •
edited
Loading

Description

Fixed KNetProducer plus added new API on KNetProducer, fixed Dispose of KNetConsumer, reviewed KNetCompactedReplicator synchronization

Related Issue

Closed #219

Motivation and Context

How Has This Been Tested?

Locally tested without add new tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@masesdevelopers
#219 (comment): fixed KNetProducer plus added new API on KNetProducer…
8782695 
…, fixed Dispose of KNetConsumer, reviewed KNetCompactedReplicator synchronization
@masesdevelopers masesdevelopers added bug Something isn't working enhancement New feature or request KNet KNet related issue labels Aug 28, 2023
@masesdevelopers masesdevelopers self-assigned this Aug 28, 2023
@masesdevelopers masesdevelopers merged commit ac5759e into masesgroup:master Aug 28, 2023
7 checks passed
@masesdevelopers masesdevelopers deleted the 219-using-knetcompactedreplicator-a-systemargumentnullexception-is-raised-in-knetproducer branch August 28, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@masesdevelopers masesdevelopers

Labels
bug Something isn't working enhancement New feature or request KNet KNet related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using KNetCompactedReplicator a System.ArgumentNullException is raised in KNetProducer
1 participant
@masesdevelopers