Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix KNetProducerRecord to conform to Apache Kafka expectation #224

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Fix KNetProducerRecord to conform to Apache Kafka expectation #224

merged 2 commits into from
Aug 31, 2023

Conversation

masesdevelopers
Copy link
Contributor

Description

The PR changes the way the data are reported in case they are not set when a KNetProducerRecord is created. This will help to conform to Apache Kafka requirements of ProducerRecord.

Related Issue

Closed #223

Motivation and Context

How Has This Been Tested?

Locally tested

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@masesdevelopers masesdevelopers added bug Something isn't working KNet KNet related issue labels Aug 31, 2023
@masesdevelopers masesdevelopers self-assigned this Aug 31, 2023
@masesdevelopers masesdevelopers merged commit ba025ee into masesgroup:master Aug 31, 2023
6 checks passed
@masesdevelopers masesdevelopers deleted the 223-knetproducer-stores-a-wrong-timestamp-if-not-explicitly-set branch August 31, 2023 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working KNet KNet related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KNetProducer stores a wrong timestamp if not explicitly set
1 participant