Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KNet uses Java.Lang.String instead of string (System.String) in generated classes #420

Merged
merged 7 commits into from
Feb 21, 2024
Merged

KNet uses Java.Lang.String instead of string (System.String) in generated classes #420

merged 7 commits into from
Feb 21, 2024

Conversation

masesdevelopers
Copy link
Contributor

Description

This PR uses latest version of JNetReflector to manage string (System.String) using the JVM Java.Lang.String type.

Related Issue

closed #416
fix #92

Motivation and Context

How Has This Been Tested?

Locally tested

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@masesdevelopers masesdevelopers added enhancement New feature or request KNet KNet related issue .NET Pull requests that update .net code labels Feb 21, 2024
@masesdevelopers masesdevelopers self-assigned this Feb 21, 2024
@masesdevelopers masesdevelopers merged commit 924fdd8 into masesgroup:master Feb 21, 2024
7 checks passed
@masesdevelopers masesdevelopers deleted the 416-avoid-use-of-string-systemstring-and-prefer-javalangstring-in-reflected-classes branch February 21, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request KNet KNet related issue .NET Pull requests that update .net code
Projects
None yet
1 participant