Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apache Kafka version update with one shot commit #69

Merged
merged 7 commits into from
May 20, 2022
Merged

Apache Kafka version update with one shot commit #69

merged 7 commits into from
May 20, 2022

Conversation

masesdevelopers
Copy link
Contributor

@masesdevelopers masesdevelopers commented May 18, 2022

Description

Apache Foundation released the version 3.2.0 of Apache Kafka. This PR updates KNet to the latest version of Apache Kafka.

Related Issue

closed #70

Motivation and Context

Align KNet to the latest version which solves bugs and introduces new functionality: see https://downloads.apache.org/kafka/3.2.0/RELEASE_NOTES.html

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@masesdevelopers masesdevelopers added the enhancement New feature or request label May 18, 2022
@masesdevelopers masesdevelopers self-assigned this May 18, 2022
Copy link
Contributor

@mariomastrodicasa mariomastrodicasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The configuration files hasn't changed? Have you checked the source code diff to verify API changes?

@masesdevelopers
Copy link
Contributor Author

The configuration files hasn't changed?

Some minor changes are available in the configuration files. Mainly in kraft.

Have you checked the source code diff to verify API changes?

Yes, there are some changes

@mariomastrodicasa
Copy link
Contributor

The configuration files hasn't changed?

Some minor changes are available in the configuration files. Mainly in kraft.

Update the files

Have you checked the source code diff to verify API changes?

Yes, there are some changes

We need to align the code: the HEAD of master is aligned to the patch 3.1.1. We have to continue to use that version until the API are aligned to the version 3.2.0.

@mariomastrodicasa
Copy link
Contributor

I opened a new issue (#70) to track the alignment to the latest Apache Kakfa version.

@masesdevelopers masesdevelopers linked an issue May 20, 2022 that may be closed by this pull request
@masesdevelopers
Copy link
Contributor Author

The configuration files hasn't changed?

Some minor changes are available in the configuration files. Mainly in kraft.

Update the files

Configuration files aligned

Have you checked the source code diff to verify API changes?

Yes, there are some changes

We need to align the code: the HEAD of master is aligned to the patch 3.1.1. We have to continue to use that version until the API are aligned to the version 3.2.0.

The PR now covers the changes identified using a source tree compare.

@mariomastrodicasa
Copy link
Contributor

The configuration files hasn't changed?

Some minor changes are available in the configuration files. Mainly in kraft.

Update the files

Configuration files aligned

Have you checked the source code diff to verify API changes?

Yes, there are some changes

We need to align the code: the HEAD of master is aligned to the patch 3.1.1. We have to continue to use that version until the API are aligned to the version 3.2.0.

The PR now covers the changes identified using a source tree compare.

If the changes are only incremental this PR can be merged into master and the version 1.3.0 will directly move to Apache Kafka version 3.2.0.

mariomastrodicasa
mariomastrodicasa approved these changes May 20, 2022
@masesdevelopers masesdevelopers merged commit a293b5d into masesgroup:master May 20, 2022
@masesdevelopers masesdevelopers deleted the UpdateKafkaVersion branch May 20, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align KNet to latest Apache Kafka version
2 participants