Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

objectNotation fix #210

Merged
merged 4 commits into from
Feb 21, 2016
Merged

objectNotation fix #210

merged 4 commits into from
Feb 21, 2016

Conversation

dangreen
Copy link
Contributor

No description provided.

@mashpie
Copy link
Owner

mashpie commented Feb 20, 2016

could you please outline your issue a bit and even add regression test?

@dangreen
Copy link
Contributor Author

You make a mistake in code. When . is first or last character objectNotation should be "disabled".

@mashpie mashpie added this to the 0.9.0 - feature improvements milestone Feb 20, 2016
@mashpie
Copy link
Owner

mashpie commented Feb 20, 2016

ah, ok. @oliversalzburg: how about your branch?

mashpie added a commit that referenced this pull request Feb 21, 2016
@mashpie
Merge pull request #210 from dangreen/master
970fcd5 
objectNotation fix
@mashpie mashpie merged commit 970fcd5 into mashpie:master Feb 21, 2016
@mashpie mashpie modified the milestones: 0.9.0 - feature improvements, 0.8.0 - enhanced plural Feb 27, 2016
@dangreen
Copy link
Contributor Author

dangreen commented May 6, 2016

@mashpie in current version again (0 < indexOfDot && indexOfDot < singular.length) instead (0 < indexOfDot && indexOfDot < singular.length - 1), why ?

@mashpie
Copy link
Owner

mashpie commented May 6, 2016

looks like the whole PR is lost... no idea right now - will need to reaply

@dangreen
Copy link
Contributor Author

dangreen commented May 6, 2016

@mashpie okay, I will made new pr, with new fixes.

@mashpie
Copy link
Owner

mashpie commented May 6, 2016

great, that'd be nice - but how to explain that? I even can't find any of your changes in history, ie.: https://github.com/mashpie/i18n-node/commits/master/test/i18n.objectnotation.js

@dangreen dangreen mentioned this pull request May 6, 2016
Closed
@dangreen
Copy link
Contributor Author

dangreen commented May 6, 2016

@mashpie https://github.com/mashpie/i18n-node/blob/master/locales/en.json#L111 in this file changes are saved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.0 - enhanced plural
Development

Successfully merging this pull request may close these issues.
2 participants
@dangreen @mashpie