setCatalog - allow your app to write updated translations back to file

[adam-clarey]

This simple addition allows your app to write an updated catalog back to file. Meaning all translation management can be handled directly in your map and doesn't require someone to manually edit each translation file

[mashpie]

simple and nice - but needs test coverage

[adam-clarey]

Is that something I need to do? How would it be achieved?

[mashpie]

it would help a lot if you provide a test to get that merged quick. If not, I will add tests to describe that use case directly after merge, but with patience ;)

[adam-clarey]

Whats the quickest way to get this merged in? I've added this module as a dependency for our js CMS - Iris. https://github.com/CityWebConsultants/Iris

I just don't know what you're expecting in the way of tests. This change is so simple and minor that I can't see anyway of it causing problems. It should be a non-breaking addition.

[mashpie]

I won't discuss the need for tests here :) each feature should be describe by a test (https://github.com/mashpie/i18n-node/tree/master/test) to ensure it's proper functionality even after future changes.

Anyway, I will add tests for you as far as I can imagine your implementation goals. Next Release will be after vacation in about 2 or 3 weeks.

[mashpie]

one things keeps me wondering: i18n configured with updateFiles: true always populates new phrases to catalogs. The write() method never writes anything with updateFiles: false, yet. So how do you add any locales without updateFiles: true? But setting updateFiles: true will add any new phrase and write back the whole locale like your setCatalog would do.

Your implementation of setCatalog does nothing than writing to filesystem, even without updating in memory locales. In addition it doesn't check for existence of parameters, so you might loose all of your translations when invoked with locale. I don't think this is intended, right?

[mashpie]

I assume this describes you use case, right?

TestScope.setCatalog({en: {'Hello World': 'new World'}}); // --> should write to fs and update in memory
TestScope.getLocale(); // --> 'en'
TestScope.getCatalog('en'); // --> {'Hello World': 'new World'}
TestScope.__('Hello World'); // --> 'new World'

but how about some edge cases?

TestScope.setCatalog({'Hello World': 'new World'}); // --> should update of current locale only?
TestScope.setCatalog(); // --> should return without action or clear all???

[mashpie]

one last thing: the signature of that method should fit it's "getter" https://github.com/mashpie/i18n-node#i18ngetcatalog

[rajkissu]

I'm trying to add new translations on the fly via node-i18n for the languages my app needs, setCatalog seems like the best way to do it:

i18n.setCatalog({
  en: {'Hello World': 'Hello World'},
  ms: {'Hello World': 'Hai dunia'},
  ...
})

__('Hello World') => returns 'Hai dunia' if locale set to 'ms'

However, I see you have removed the setCatalog method @mashpie - what's the reason for this, if you don't mind me asking? Is there another way to do this, hence the removal?