Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some improvements #395

Merged
merged 9 commits into from
Apr 16, 2019
Merged

Some improvements #395

merged 9 commits into from
Apr 16, 2019

Conversation

rimiti
Copy link
Contributor

@rimiti rimiti commented Mar 18, 2019

Hello,

Some improvements:

  • Force mocha to exit.
  • sprintf-js + async + cookie-parser + express packages updated.
  • package-lock.json tracked.
  • CI fixed.
  • CI updated for running tests on NodeJS Current + LTS (io.js has merged with the Node.js project again. There won't be any further io.js releases. All of the features in io.js are available in Node.js v4 and above.)
  • GLOBAL removed for global (GLOBAL is deprecated).
  • appveyor.yml removed (it's useless to have two CI/CD).
  • Duplicate license block removed from README.md (LICENSE file exists)
  • Broken and unless badges removed.

Regards, 🚀

@rimiti
Copy link
Contributor Author

rimiti commented Mar 18, 2019

@mashpie It can be safely merged and released. 🤓

Note: If you need a maintainer, I'm in!

@SISheogorath
Copy link

@rimiti Not sure if @mashpie is reading it, I still think it would be great to have a successor for this library :)

@mashpie
Copy link
Owner

mashpie commented Apr 16, 2019

...I fucked up notifications again.

@rimiti Thanks a lot, super helpful and crucial to proceed with maintenance
@SISheogorath Thanks for pointing...

@mashpie mashpie merged commit 83caab3 into mashpie:master Apr 16, 2019
@ccoenen
Copy link

ccoenen commented Apr 16, 2019

Appveyor may have served a purpose; it is usually run in a windows environment, whereas travis has to be configured to do so manually. It could be added to the travis config to run on Linux and Windows. more travis/windows references

Here is one of the more recents build (~4 months ago), when appveyor ran successfully: https://ci.appveyor.com/project/mashpie/i18n-node/builds/20882799/job/4cn4bfkktkmcw397

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants