Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ltex): use platform-specific releases for win/mac #4311

Merged
merged 1 commit into from
Feb 20, 2024
Merged

fix(ltex): use platform-specific releases for win/mac #4311

merged 1 commit into from
Feb 20, 2024

Conversation

chrisgrieser
Copy link
Contributor

@chrisgrieser chrisgrieser commented Jan 27, 2024

The main intent is to remove the external dependency on a JRE, thus fixing: williamboman/mason.nvim#1531 & valentjn/ltex-ls#187

Implements #2837, but also for mac. Linux still uses the platform-independent release, to ensure compatibility with arm64.

Copy link
Member

@williamboman williamboman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable! It seems like it'll only end up using the bundled Java runtime if $JAVA_HOME is unset. This is probably an issue best directed upstream (maybe the release assets with a bundled runtime shouldn't respect $JAVA_HOME)

@williamboman williamboman merged commit 8036fcc into mason-org:main Feb 20, 2024
19 checks passed
@chrisgrieser
Copy link
Contributor Author

indeed, with the bundled JRE, there is no need anymore to set JAVA_HOME. Yet another problem solved.

williamboman added a commit to Conarius/mason-registry that referenced this pull request Feb 21, 2024
* origin/main: (974 commits)
  bump(jdtls): update to v1.33.0 (mason-org#4567)
  bump(nextls): update to v0.17.1 (mason-org#4559)
  bump(gitui): update to v0.25.0 (mason-org#4635)
  bump(snakefmt): update to v0.10.0 (mason-org#4373)
  feat(crystalline): add support for darwin_arm64 (mason-org#4474)
  chore(jsonnetfmt): fix languages (mason-org#4507)
  bump(perl-debug-adapter): update to 1.0.7 (mason-org#4471)
  bump(snyk-ls): update to v20240221 (mason-org#4634)
  bump(slang): update to v2024.0.7 (mason-org#4633)
  feat: add glsl_analyzer (mason-org#4578)
  feat: add vscode-solidity-server (mason-org#4575)
  chore(dprint): dprint can act as its own language server (mason-org#4366)
  feat(ltex-ls): use platform-specific releases for win/mac (mason-org#4311)
  feat: add nixpkgs-fmt (mason-org#4290)
  bump(blade-formatter): update to v1.41.0 (mason-org#4632)
  bump(prisma-language-server): update to v5.10.1 (mason-org#4630)
  bump(vacuum): update to v0.9.9 (mason-org#4631)
  feat: add hclfmt (mason-org#4280)
  bump(pint): update to v1.14.0 (mason-org#4629)
  bump(trufflehog): update to v3.67.7 (mason-org#4628)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants