Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Markdown Oxide #4683

Merged
merged 3 commits into from
Mar 17, 2024
Merged

Conversation

Feel-ix-343
Copy link
Contributor

@williambotman williambotman requested a review from a team February 25, 2024 03:52
@Feel-ix-343 Feel-ix-343 changed the title Add support for my language server, Markdown Oxide Add support for Markdown Oxide Feb 25, 2024
@chrisgrieser
Copy link
Contributor

Just a heads-up: releasing binaries is somewhat preferable for mason packages. When the user does not have the rust toolchain installed, they will not be able to install this package:
Pasted image 2024-03-05 at 11 20 31@2x

Copy link
Member

@williamboman williamboman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I modified the source definition to leverage cargo's builtin support for installations from remote git repositories.

@williamboman williamboman merged commit 353277f into mason-org:main Mar 17, 2024
19 checks passed
@Feel-ix-343
Copy link
Contributor Author

This is great!

And eventually the LS will have a binary. However, things are changing so fast.

Also @williamboman, with the changes you made, how will new versions be released? Will it happen just when I push a tag?

@williamboman
Copy link
Member

Also @williamboman, with the changes you made, how will new versions be released? Will it happen just when I push a tag?

Yeah it'll track tags in the provided GitHub repository.

@Feel-ix-343
Copy link
Contributor Author

Feel-ix-343 commented Mar 18, 2024

Note: I just made a PR in mason-lspconfig here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants