Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2: improve package structure and replace mux with gin #2

Merged
merged 1 commit into from
Sep 1, 2021
Merged

v2: improve package structure and replace mux with gin #2

merged 1 commit into from
Sep 1, 2021

Conversation

waltzofpearls
Copy link
Contributor

@waltzofpearls waltzofpearls commented Aug 29, 2021 •
edited
Loading

  • Simpler subfolder and package structure
  • Replaced Gorilla Mux with Gin
  • Better Logger middleware with zap
  • Improved graceful shutdown with cancelable context

chazlett
chazlett approved these changes Aug 31, 2021
View reviewed changes
Copy link
Contributor

@chazlett chazlett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thanks for improving everything, but especially logging. I did it very naively before and this is much better.

terapaks
terapaks approved these changes Sep 1, 2021
View reviewed changes
v2/examples/graphql/graph/status.graphqls
# https://gqlgen.com/getting-started/

type Status {
State: String!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is String!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Response from Rollie: this is graphql specific generated code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exclamation marks a field to be non-nullable. https://graphql.org/learn/schema/#object-types-and-fields

@waltzofpearls waltzofpearls merged commit 3157ddb into master Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terapaks terapaks terapaks approved these changes

@chazlett chazlett chazlett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waltzofpearls @chazlett @terapaks