Update yabs.sh #20
Merged
Update yabs.sh #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proposed resolution for masonr#13 - Just throws a warning to the user. Tested as working as intended on a ZFS filesystem
|
Good commit, thanks for the help with this one! Wasn't too sure how to approach it without access to a ZFS-based host. Cheers! |
Thanks! Looking at it again now there are a few syntax things that could be cleaned up in this commit - it was a bit quick and dirty, but it seems to work in all the tests we have done. Besides, this will only kick in on a ZFS enabled system and at most show a warning, so if there are some edge cases lurking here they will not be detrimental to overall functionality |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed resolution for #13 - Just throws a warning to the user. Tested as working as intended on a ZFS filesystem