Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial code for wasmer 3.0 #8

Merged
merged 10 commits into from
Dec 19, 2022
Merged

Initial code for wasmer 3.0 #8

merged 10 commits into from
Dec 19, 2022

Conversation

sydhds
Copy link

@sydhds sydhds commented Nov 30, 2022

No description provided.

@sydhds sydhds marked this pull request as draft November 30, 2022 17:53
@sydhds
Copy link
Author

sydhds commented Dec 8, 2022

Linked PR:

AurelienFT
AurelienFT reviewed Dec 9, 2022
View reviewed changes
Copy link

@AurelienFT AurelienFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a big pro of the migration WASMER 3.0 but it seems to be coherent.

src/any_ptr.rs Outdated Show resolved Hide resolved
src/buffer_ptr.rs Outdated Show resolved Hide resolved
src/string_ptr.rs Outdated Show resolved Hide resolved
src/string_ptr.rs Show resolved Hide resolved
Eitu33
Eitu33 reviewed Dec 14, 2022
View reviewed changes
src/env.rs Show resolved Hide resolved
@Eitu33 Eitu33 mentioned this pull request Dec 15, 2022
Closed
@AurelienFT AurelienFT mentioned this pull request Dec 16, 2022
Open
@AurelienFT AurelienFT marked this pull request as ready for review December 19, 2022 10:30
@AurelienFT AurelienFT merged commit d40a158 into main Dec 19, 2022
@bors bors bot deleted the test/wasmer_3_switch branch December 19, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AurelienFT AurelienFT AurelienFT approved these changes

@Eitu33 Eitu33 Awaiting requested review from Eitu33

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sydhds @AurelienFT @Eitu33