Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use condom #336

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Use condom #336

merged 1 commit into from
Sep 23, 2024

Conversation

damip
Copy link
Member

@damip damip commented Aug 13, 2024

Add an entry-point protection middleware that prevents malicious WASM files from reaching the compilation step.

TODO:

@Leo-Besancon Leo-Besancon changed the base branch from main to next_breaking_update August 14, 2024 07:52
src/as_execution/mod.rs Outdated Show resolved Hide resolved
src/middlewares/condom.rs Outdated Show resolved Hide resolved
Cargo.toml Show resolved Hide resolved
Copy link
Contributor

@Leo-Besancon Leo-Besancon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements! The proposed values seem reasonable to me (both for the limits set and the times reached).

src/middlewares/condom.rs Outdated Show resolved Hide resolved
src/middlewares/condom.rs Show resolved Hide resolved
With the limits imposed to wasm files, over 10 runs,
- the average compilation time is 328.83ms
- max time: 518ms
- min time: 247ms
- standard deviation: 93.47ms
(see test_condom_middleware_calibrate for details)

Also:
- Update ffi, wasmer version, and ci
- Fix calibration tests

Co-authored-by: Damir Vodenicarevic <damipator@gmail.com>
Co-authored-by: Leo-Besancon <leoleo38@live.fr>
Co-authored-by: Jean-François <jfm@laposte.net>

Signed-off-by: Jean-François <jfm@laposte.net>
@bilboquet bilboquet merged commit c00be0a into next_breaking_update Sep 23, 2024
10 of 11 checks passed
@bilboquet bilboquet deleted the add_condom branch September 23, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants