-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use condom #336
Merged
Merged
Use condom #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leo-Besancon
force-pushed
the
add_condom
branch
from
August 14, 2024 07:52
9a62f0b
to
d589bc4
Compare
damip
commented
Aug 14, 2024
damip
commented
Aug 14, 2024
8 tasks
bilboquet
reviewed
Aug 28, 2024
bilboquet
reviewed
Sep 18, 2024
Leo-Besancon
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvements! The proposed values seem reasonable to me (both for the limits set and the times reached).
With the limits imposed to wasm files, over 10 runs, - the average compilation time is 328.83ms - max time: 518ms - min time: 247ms - standard deviation: 93.47ms (see test_condom_middleware_calibrate for details) Also: - Update ffi, wasmer version, and ci - Fix calibration tests Co-authored-by: Damir Vodenicarevic <damipator@gmail.com> Co-authored-by: Leo-Besancon <leoleo38@live.fr> Co-authored-by: Jean-François <jfm@laposte.net> Signed-off-by: Jean-François <jfm@laposte.net>
bilboquet
force-pushed
the
add_condom
branch
from
September 20, 2024 18:26
9609ff8
to
0608113
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an entry-point protection middleware that prevents malicious WASM files from reaching the compilation step.
TODO:
next_breaking_update
max_exports
to the config on the massa side, make it properly link to massa-sc-runtime