Clean bootstrap state and versioning cursors #4053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Leo-Besancon
commented
Jun 7, 2023
•
Leo-Besancon
commented
- document all added functions
- try in sandbox /simulation/labnet
- unit tests on the added/changed features
- make tests compile
- make tests pass
- add logs allowing easy debugging in case the changes caused problems
- if the API has changed, update the API specification
|
/!\ This PR includes a fix on the versioning changes bootstrap. |
12 tasks
sydhds
approved these changes
Jun 8, 2023
Leo-Besancon
added a commit
that referenced
this pull request
Jun 8, 2023
* Initial rework of get_batch_to_stream and get_versioning_batch_to_stream * Updated write_batch_bootstrap_client and server cursors' logic
damip
pushed a commit
that referenced
this pull request
Jun 9, 2023
* Update testnet24 * first commit for monitoring channel * change counter after recv instead of before * create channels.rs file * add counter for blocks && operations * add comment and log * add "channel" in channel metrics field * rework MassaChannel * remove crossbeam channel from massa-protocol-worker * actual_len and received are now optional (if metrics feature) * unregister metrics when recverror or when no receiver left * if metrics enable set final cursor in execution * execution : active_cursor * move channel in massa-channel package Add optional on massa-metrics (compile time) remove Option and add feature on field * remove duplicate * fix feature * update block and operation to Gauge * update consensus with MassaChannel * Change ip * change channel in massa-execution-worker * add metric for endorsements * add inc_metric on select! and use MassaChannel in massa-factory * Add debug print * Add mor eprint * add in / out conn in metrics * Add an operation injector * Clean bootstrap state and versioning cursors (#4053) * Initial rework of get_batch_to_stream and get_versioning_batch_to_stream * Updated write_batch_bootstrap_client and server cursors' logic * cargo fmt fix after merge testnet23 * Fix injector * add consensus metrics add metrics by default * remove modification on ledger * Setup op_spammer feature * Change version * fix operation injector * remove metrics feature * Fix cache size * add metrics for block_cache and operation_cache * add metrics for retrieval_thread_stored_operations_sum * bloc -> block * Improve op injector * add metrics for consensus state index remove max_known_blocks_by_peer * change op injector * Change cache checked operations * Fix cache * remove changes * fix warning && clippy * fix cache sizes * remove change sandbox version * update outdated addresses * update unit test * update version * remove unused dependency * remove unused crate * fix massa metrics testing * comment a buggy test * Fix warnings * Fix test --------- Co-authored-by: modship <yeskinokay@gmail.com> Co-authored-by: Leo-Besancon <lb@massa.net>
AurelienFT
pushed a commit
that referenced
this pull request
Jun 15, 2023
* Initial rework of get_batch_to_stream and get_versioning_batch_to_stream * Updated write_batch_bootstrap_client and server cursors' logic
AurelienFT
added a commit
that referenced
this pull request
Jun 15, 2023
This reverts commit 08f7601.
damip
added a commit
that referenced
this pull request
Jun 15, 2023
* Update testnet24 * Split massa db as worker and exports (#4045) * 1st step to have massa_db split between exports and worker * Create MassaDBController trait * Implement MassaDBController for MassaDB * Added read function to MassaDBController * Started cleaning up build errors - not finished * Implemented more trait methods, cleaned a bit Still has lifetime issues and some trait methods missing, e.g. for bootstrap * Fixed build errors * Fix after rebase on testnet24 * Fix clippy warnings * Simplified lifetime definitions * Added doc comments * Updated doc comments for get_batch and get_versioning_batch * In pos-exports, put the massa-db-worker as a dev-dependency instead of optional dependancy * Make pub * Make RawMassaDB fileds pub * Clean bootstrap state and versioning cursors (#4053) * Initial rework of get_batch_to_stream and get_versioning_batch_to_stream * Updated write_batch_bootstrap_client and server cursors' logic * secure denunciation pool * correct errors * operation pool refactoring * op pool filtering (no scoring yet) * updates * update executed ops * scoring ops * full compile * optimize * Fix test compilation * better endo expiry * update constants * minor improvements on scoring * Fix tests of pool. * Revert "Clean bootstrap state and versioning cursors (#4053)" This reverts commit 08f7601. * Revert "Make RawMassaDB fileds pub" This reverts commit 730c6e2. * Revert "Make pub" This reverts commit 9e43bbe. * Revert "Split massa db as worker and exports (#4045)" This reverts commit c1379f2. * Use cargo lock from main * Fix grpc compilation * Fix config variable * Test endorsements in protocol * Fix tests * Fix protocol test --------- Co-authored-by: AurelienFT <aurelien.foucault@epitech.eu> Co-authored-by: Leo-Besancon <lb@massa.net> Co-authored-by: Leo-Besancon <leoleo38@live.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.