Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrimaryButton #27

Closed
Tracked by #26
maxime-carabina opened this issue Apr 28, 2023 · 3 comments
Closed
Tracked by #26

PrimaryButton #27

maxime-carabina opened this issue Apr 28, 2023 · 3 comments
Assignees

Comments

@maxime-carabina
Copy link
Contributor

maxime-carabina commented Apr 28, 2023

image

-it can contain an icon on the left, on the right or even both
-it can contain text
-it can change color according to the theme
-it has different states :

  • default
  • hover
  • pressed
  • disabled
@maxime-carabina maxime-carabina mentioned this issue Apr 28, 2023
2 tasks
@maxime-carabina maxime-carabina changed the title Primary PrimaryButton Apr 28, 2023
@maxime-carabina maxime-carabina self-assigned this Apr 28, 2023
@maxime-carabina maxime-carabina linked a pull request May 3, 2023 that will close this issue
@pivilartisant pivilartisant added P1 and removed P1 labels May 5, 2023
@SlnPons
Copy link

SlnPons commented May 10, 2023

Test blocked by: #35

@SlnPons
Copy link

SlnPons commented May 10, 2023

@maxime-carabina I believe that the "hover" of the primary button for the light-theme doesn't match the design.
We can see a border that doesn't exist on the design. @LucasF243 can you confirm the expected result please?

Image

If the hover needs some rework, it's not a big deal :)
Let's finish what you do now and open a new PR to correct this when we have time.

@SlnPons
Copy link

SlnPons commented May 10, 2023

I can confirm we have a problem with the border.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants