Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added colors #35

Merged
merged 10 commits into from
May 10, 2023
Merged

added colors #35

merged 10 commits into from
May 10, 2023

Conversation

Pierregvx
Copy link
Contributor

No description provided.

@Pierregvx Pierregvx linked an issue May 3, 2023 that may be closed by this pull request
Add colors to the storybook #34
Closed
2 tasks
mazmassa
mazmassa reviewed May 3, 2023
View reviewed changes
Copy link
Contributor

@mazmassa mazmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have an image of how looks like the Storybook on the description field. If you could add also a tiny content explaining that it would be cool to get the context.

src/components/Colors/Colors.tsx Outdated Show resolved Hide resolved
src/components/Colors/Colors.tsx Outdated Show resolved Hide resolved
Thykof
Thykof reviewed May 3, 2023
View reviewed changes
Copy link
Contributor

@Thykof Thykof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of Color and Colors components?

If we will not use them in a real application (wallet...) I think we only need to create a story for the storybook.

src/components/Colors/Colors.tsx Outdated Show resolved Hide resolved
src/components/Colors/Colors.tsx Outdated Show resolved Hide resolved
pivilartisant
pivilartisant reviewed May 5, 2023
View reviewed changes
Copy link
Contributor

@pivilartisant pivilartisant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be rebased and changed according to recent changes

presets/massa-station-preset.js Show resolved Hide resolved
@Pierregvx Pierregvx force-pushed the 34-add-colors-to-the-storyboof branch from 1de941f to ca5ef36 Compare May 5, 2023 13:46
maxime-carabina
maxime-carabina reviewed May 9, 2023
View reviewed changes
Copy link
Contributor

@maxime-carabina maxime-carabina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping me when its done

src/components/Colors/Color/Color.tsx Outdated Show resolved Hide resolved
src/components/Colors/Color/Color.tsx Outdated Show resolved Hide resolved
@Pierregvx Pierregvx force-pushed the 34-add-colors-to-the-storyboof branch from b789a3b to 1e05707 Compare May 9, 2023 09:41
maxime-carabina
maxime-carabina approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@maxime-carabina maxime-carabina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced May 10, 2023
Closed
Closed
@SlnPons
Copy link

SlnPons commented May 10, 2023

@Pierregvx this PR is in code review for a very long time. Please make sure to solve the comment ASAP so we can merge it.
It's blocking the story book to be tested correctly ;)
Also for front-end tickets, the review process is: 1) Paul or Max, 2) Mario. That's it! Way too many devs on this PR

Pierregvx and others added 10 commits May 10, 2023 09:40
@Pierregvx
added colors
7cbe889
@Pierregvx
added keys
c1c6627
@Pierregvx
added error color
65e6daa
@Pierregvx
modified div styles
5fc36e4
@Pierregvx @mazmassa
Update src/components/Colors/Colors.tsx
bf3c8f4 
Co-authored-by: MaZ <126461030+mazmassa@users.noreply.github.com>
@Pierregvx
updated color in storybook
76351db
@Pierregvx
added warning success & error
a2e3516
@Pierregvx
Update massa-station-preset.js
73d89c9
@Pierregvx @maxime-carabina
Update src/components/Colors/Color/Color.tsx
df0afb9 
Co-authored-by: Maxime Carabina <72019005+maxime-carabina@users.noreply.github.com>
@Pierregvx @maxime-carabina
Update src/components/Colors/Color/Color.tsx
0c2abef 
Co-authored-by: Maxime Carabina <72019005+maxime-carabina@users.noreply.github.com>
@Pierregvx Pierregvx force-pushed the 34-add-colors-to-the-storyboof branch from 1e05707 to 0c2abef Compare May 10, 2023 07:40
@Pierregvx Pierregvx merged commit fdb8362 into main May 10, 2023
@Pierregvx Pierregvx deleted the 34-add-colors-to-the-storyboof branch May 10, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thykof Thykof Thykof left review comments

@pivilartisant pivilartisant pivilartisant approved these changes

@maxime-carabina maxime-carabina maxime-carabina approved these changes

@mazmassa mazmassa mazmassa approved these changes

Assignees

@Pierregvx Pierregvx

Labels
P3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add colors to the storybook
6 participants
@Pierregvx @SlnPons @Thykof @maxime-carabina @pivilartisant @mazmassa